/
2023 Handover Meeting

2023 Handover Meeting

Participants

  • @Gabriel Ting (Unlicensed)

  • @Peter Derias (Unlicensed)

  • @Leonardo Fan (Unlicensed)

  • @Hussain Nawaz (Unlicensed)

Apologies

Discussion topics

Topic

Context and Discussion Points

Action Items and Decisions

Topic

Context and Discussion Points

Action Items and Decisions

General

2022 Reflections

  1. happy

Feature Expansion

  • Peter and I collated some ideas on what you could do next year: Future Ideas for 2023. Feel free to take ideas or go with your own!

  • To note, once backend migration is completed, it unlocks of new feature ideas that previously weren’t avaliable to us. For example: planner profiles, sharing degrees, social degree planning?

  • shared ideas between

CSESoc Projects Integration

  • There were talks on integrating with other csesoc projects (i.e. one csesoc app similar to NUS mods NUSMods) so keep an eye out on this. Try to keep in mind this point vs your own goals for Circles aswell as you may need to priorites different tasks.

 

 

Subcom recruitment

  • Reach out to the current Circles team members if they are interested in sticking around next year. Feel free to message Peter/Gabriel aswell!

 

Links

  • Figma

    • we have 2021 link (not used much, just used as a ref but at this point, you’ll probs wont need it and its more as an fyi) Circles

    • we have a 2022 link Circles 2022

      • Just to note, Christian Lam was mainly using Figma to design the landing page (and he made a copy of the 2022 Circles Figma on his own account) so you may need to reach out to him if the 2022 figma link designs is outdated

      • 2022 has some designs I (Gabriel) noted i.e. WAM tracker, redesign for Degree Wizard but never actually implemented. Feel free to use it or not.

  • Jira

    • We have seperate boards for FE and BE. Though you may want to consider combining both boards to one next year if you guys are not doing the split? @Peter Derias (Unlicensed) agrees.

  1. find out if you want a new link for figma
  2. do you want to use linear?

Carry-over work (Frontend)

Prerequisite Tree

  • @Leonardo Fan (Unlicensed) should already know the deets: https://compclub.atlassian.net/browse/CF-296

  • All that remains is to utilise the /courses/jsonified/{course} route to show prerequisites in a tree layout (currently, it only shows all courses on one level)

 

Graphical Selector

  • Some of the GS tickets are spread out between Oliver, Xing and myself. You need to check up on the statuses behind these and plan forward.

  • Also, while the core functionality is in place, I would say that there is alot if improvements that could be made before release.

  • https://compclub.atlassian.net/browse/CF-256

 

Landing Page

  • Christian mainly worked on the design + implementation (with the help of Kellie) for it. Landing page is mostly done. There is some stuff to be done i.e. making it the root route, some bugs?

  • Also, as a note, in terms of design, something should be added between ‘How it works’ section and the footer. There needs to be a smoother transition. Perhaps a shill section to join Circles/see the circles repo/give feedback? Similar to jobsboard ‘Looking for more?’ section Jobsboard

 

Auto planning (FE)

 

Writing FE tests

  • Early T3, I wrote some tests for the FE. Right now, only the Degree Wizard and Course Selector page have some tests (although a bit basic). It would be good if we have FE tests written for most component but it’s not a priority over new features.

  • @Peter Derias (Unlicensed) disagrees. Write tests during the holidays, it's the best time to do it. It's impossible to give your subcom tech debt tickets and you probably won't have the time later. Enforce good practices from the start.

  • We also have some testing tickets assigned to some subcom but I’m not sure on the status behind those . You need to check up on the statuses.

  • Some notes on testing: Frontend Testing

  • https://compclub.atlassian.net/browse/CF-361

 

Ant Design v5 Migration

 

Misc stuff

  • In dev features

    • Right now, we have an in dev flag to conditionally render in dev features (i.e. graphical selector, landing page). Ideally, we should also have another ‘staging’ environment to render these features. You may need to discuss with Jared to set it up @Peter Derias (Unlicensed) thinks that you should just put them on prod, but hide the URL using environment vars.

  • Cypress tests

    • I wanted to investigate doing some cypress testing https://compclub.atlassian.net/browse/CF-316 but didn’t have enough time. This would be good as it could detect breaking changes from dep updates - functionality wise.

  • Lazy loading

    • One of the issues we have is lazy loading. We are currently loading each pages separately. At times, some modules can’t be loaded, throwing an error. The reason we do this is to reduce the initial JS file sent to the client + improve SEO

    • Also keep in mind adding new packages as it may introduce bloat to the initial JS file size. If this happens, try to see if lazy loading is needed.

    • NOTE: Please be careful with some dep updates with FE packages. For example, there was an issue upgrading react-tooltip from 4.2.21 to the latest version. One time, updating the version caused Circles to throw an error on some browsers. I think the issue was that since we were lazy loading the pages, react-tooltip is an overlay, lazy loading the package caused an issue. TBH this is my guess and never had the time to fix this.

 

 

 

 

Carry-over work (Backend)

Data Migration

  • Need a decorator for converting token to user

  • refactoring redux slices to api calls is mostly done, but degree slice still not done

  • Need to integrate with FE

  • will have a mess with figuring out async code

Auto planning

I will try to get this done before I go. Issue lies with using DegreeData instead of PlannerData.

 

Github Feedback Issues Automation

Credentials and ownership of form?

Talk to @Mae Vuong (Unlicensed) to get the credentials, and then talk to @Jared Lohtaja (Unlicensed) to get the info in Vault.

 

Maturity requirements

Need to get that done soon but you would be following this more closely than me.

However, over the holidays the focus should be on getting rid of debt.

 

BUSINESS WITHOUT NOTICE

Cutover

  • When does @Leonardo Fan (Unlicensed) @Hussain Nawaz (Unlicensed) want a full cutover of responsibility?

    • I’m (@Gabriel Ting (Unlicensed) happy to do some stuff here and there for the FE side until Dec 18th (i.e. reviewing PRs, approving deps update, developing/merging minor features?) but after that, it’s own you guys to manage the repo

    • Yup @Peter Derias (Unlicensed) thinks that this week should be when you're the boss.

    • It’s assumed that any PRs/ticket progress after the 18th will be on you guys to managed

 

Useful links

Related content